Add AWS provider #1
Merged
+2,297
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmmbaga
force-pushed
the
add-aws-provider
branch
from
62ae236
to
ae4c623
Compare
bcmmbaga
force-pushed
the
add-aws-provider
branch
7 times, most recently
from
6808bfe
to
bf43e36
Compare
|
It seems that the spinner messes up the logs in some way. It might be due to the newline at the end. Does this happen on your end as well? Also, the spinner should hide the terminal cursor and then reveal it once it stops. There is a terminal character that, when written, hides/shows the cursor. Look into that please. |
bcmmbaga
force-pushed
the
add-aws-provider
branch
7 times, most recently
from
00e1fd6
to
9f6a070
Compare
Signed-off-by: bcmmbaga <[email protected]>
bcmmbaga
force-pushed
the
add-aws-provider
branch
from
9f6a070
to
c027829
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AWS provider
Description
This pull request adds the implementation of AWS as a Daytona container provider.